chore: make flask-talisman work with test config #29277
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, when setting .env-local to point to the test config, by setting `SUPERSET_CONFIG=tests.integration_tests.superset_test_config`, flask-talisman has issues where it refuses to load assets because of `safe-eval`. This allows for the TALISMAN_CONFOG_DEV is used when making this import. In an upcoming PR I'm planning on documenting how to point your dev docker-compose setup to the test settings and database for interactive testing.
john-bodley
approved these changes
Jun 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Currently, when setting .env-local to point to the test config, by setting
SUPERSET_CONFIG=tests.integration_tests.superset_test_config, flask-talisman has issues where it refuses to load assets because ofsafe-eval.This allows for the TALISMAN_CONFOG_DEV is used when making this import.
In an upcoming PR I'm planning on documenting how to point your dev docker-compose setup to the test settings and database for interactive testing.