Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(alerts): enable tab selection for dashboard alerts/reports #29096
feat(alerts): enable tab selection for dashboard alerts/reports #29096
Changes from all commits
62a7c0c
803ffc0
0001f9f
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we use more specific type?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ideally, I'd like for this to be typed as
string | undefined
, but I'm running into issues from antd's typing for theonSelect
prop which is typed as'RawValueType | LabelValueType'
and throws an error on compile when typed as such. I've usedany
as a workaround.Check warning on line 614 in superset-frontend/src/features/alerts/AlertReportModal.tsx
Codecov / codecov/patch
superset-frontend/src/features/alerts/AlertReportModal.tsx#L612-L614
Check warning on line 620 in superset-frontend/src/features/alerts/AlertReportModal.tsx
Codecov / codecov/patch
superset-frontend/src/features/alerts/AlertReportModal.tsx#L620
Check warning on line 829 in superset-frontend/src/features/alerts/AlertReportModal.tsx
Codecov / codecov/patch
superset-frontend/src/features/alerts/AlertReportModal.tsx#L829
Check warning on line 833 in superset-frontend/src/features/alerts/AlertReportModal.tsx
Codecov / codecov/patch
superset-frontend/src/features/alerts/AlertReportModal.tsx#L833
Check warning on line 945 in superset-frontend/src/features/alerts/AlertReportModal.tsx
Codecov / codecov/patch
superset-frontend/src/features/alerts/AlertReportModal.tsx#L945
Check warning on line 947 in superset-frontend/src/features/alerts/AlertReportModal.tsx
Codecov / codecov/patch
superset-frontend/src/features/alerts/AlertReportModal.tsx#L947
Check warning on line 1021 in superset-frontend/src/features/alerts/AlertReportModal.tsx
Codecov / codecov/patch
superset-frontend/src/features/alerts/AlertReportModal.tsx#L1021