fix(explore): hide a control wrapped with StashFormDataContainer correctly #28555
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justinpark
force-pushed
the
fix--invalid-col-size-due-to-hidden-control
branch
from
3b1f50d
to
0d7b2ac
Compare
michael-s-molina
approved these changes
May 16, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #28555 +/- ##
==========================================
+ Coverage 60.48% 64.54% +4.05%
==========================================
Files 1931 521 -1410
Lines 76236 37483 -38753
Branches 8568 0 -8568
==========================================
- Hits 46114 24193 -21921
+ Misses 28017 13290 -14727
+ Partials 2105 0 -2105
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
justinpark
force-pushed
the
fix--invalid-col-size-due-to-hidden-control
branch
from
0d7b2ac
to
89885fa
Compare
michael-s-molina
added
the
v4.0
EnxDev
pushed a commit
to EnxDev/superset
that referenced
this pull request
May 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
With the introduction of StashFormDataContainer to stash form data while hidden, the control row visibility logic has been affected. This is because it currently only checks the direct element properties.
This commit fixes the logic to check with the correct Control component
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Before:
before--invalid-visible-check.mov
After:
after--fix-invalid-visibility.mov
TESTING INSTRUCTIONS
Open a explore to create a table chart
Resize the window over 1200px and then check the control panel
ADDITIONAL INFORMATION