chore: module scope should not require the app context #28378
+1,740
−1,168
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a major issue that's been plaguing the backend for a long time. Currently you can't simply run a simple
from superset import models
(or pretty much any other module import) without getting an error about the app context missing, and/or circular importsThis DRAFT PR tries to evaluate what's getting in the way. So far I've identified:
relationship("use-a-string-reference")
callTODO:
SQLALCHEMY_ENCRYPTED_FIELD_TYPE_ADAPTER
altogether (?) unless we can find some solutionTO-LOOK-INTO