-
Notifications
You must be signed in to change notification settings - Fork 13.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(sqllab): invalid css scope for ace editor autocomplete #28156
fix(sqllab): invalid css scope for ace editor autocomplete #28156
Conversation
@@ -22,6 +22,7 @@ import { useDispatch } from 'react-redux'; | |||
import { css, styled, usePrevious, useTheme } from '@superset-ui/core'; | |||
import { Global } from '@emotion/react'; | |||
|
|||
import { SQL_EDITOR_LEFTBAR_WIDTH } from 'src/SqlLab/constants'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needn't tackle it in this PR, but I would think layout constants like these should be global (or in the theme) since they likely could/should apply to other views in the app.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
src/SqlLab/constants.ts
looks like a good place for this constant.
(cherry picked from commit 7e94dc5)
SUMMARY
The issue has been fixed in this commit as the autocomplete container is now properly appended to the body instead of the ace container. This commit addresses and fixes the issue by applying the autocomplete style to the global.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Before:
After:
TESTING INSTRUCTIONS
Go to SQL Lab and type anything for autocomplete
ADDITIONAL INFORMATION