fix(sqllab): invalid css scope for ace editor autocomplete #28156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rusackas
reviewed
Apr 23, 2024
| @@ -22,6 +22,7 @@ import { useDispatch } from 'react-redux'; | |||
| import { css, styled, usePrevious, useTheme } from '@superset-ui/core'; | |||
| import { Global } from '@emotion/react'; | |||
|
|
|||
| import { SQL_EDITOR_LEFTBAR_WIDTH } from 'src/SqlLab/constants'; | |||
There was a problem hiding this comment.
Needn't tackle it in this PR, but I would think layout constants like these should be global (or in the theme) since they likely could/should apply to other views in the app.
There was a problem hiding this comment.
src/SqlLab/constants.ts looks like a good place for this constant.
michael-s-molina
approved these changes
Apr 25, 2024
qleroy
pushed a commit
to qleroy/superset
that referenced
this pull request
Apr 28, 2024
michael-s-molina
added
v4.0
michael-s-molina
pushed a commit
that referenced
this pull request
Apr 29, 2024
michael-s-molina
pushed a commit
that referenced
this pull request
Apr 29, 2024
(cherry picked from commit 7e94dc5)
michael-s-molina
pushed a commit
that referenced
this pull request
Apr 29, 2024
jzhao62
pushed a commit
to jzhao62/superset
that referenced
this pull request
May 16, 2024
mistercrunch
added
🍒 3.1.3
🍒 4.0.1
🍒 4.0.2
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
The issue has been fixed in this commit as the autocomplete container is now properly appended to the body instead of the ace container. This commit addresses and fixes the issue by applying the autocomplete style to the global.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Before:
After:
TESTING INSTRUCTIONS
Go to SQL Lab and type anything for autocomplete
ADDITIONAL INFORMATION