Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(commands): Remove unnecessary commit #28154

Conversation

john-bodley
Copy link
Member

@john-bodley john-bodley commented Apr 19, 2024

SUMMARY

As part of a large change related to [SIP-99B] Proposal for (re)defining a "unit of work", I'm in the process of creating some minuscule precision PRs to clean up some unnecessary/problematic logic to aid with future testing/debugging.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

CI.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@john-bodley john-bodley marked this pull request as ready for review April 19, 2024 23:56
@john-bodley john-bodley changed the title chore: Remove unnecessary commit chore(commands): Remove unnecessary commit Apr 20, 2024
@rusackas
Copy link
Member

@john-bodley any reason not to hit the enticing green button? :)

@rusackas rusackas merged commit e943604 into master May 1, 2024
56 of 57 checks passed
@rusackas rusackas deleted the john-bodley--commands-dashboard-importers-remove-unnecessary-commit branch May 1, 2024 22:09
dpgaspar pushed a commit to preset-io/superset that referenced this pull request May 6, 2024
jzhao62 pushed a commit to jzhao62/superset that referenced this pull request May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants