-
Notifications
You must be signed in to change notification settings - Fork 13.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Add custom keywords for SQL Lab autocomplete #28153
chore: Add custom keywords for SQL Lab autocomplete #28153
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR @justinpark!
docHTML?: string | undefined; | ||
docText?: string | undefined; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
docHTML?: string | undefined; | |
docText?: string | undefined; | |
docHTML?: string; | |
docText?: string; |
export function useKeywords( | ||
{ queryEditorId, dbId, schema }: Params, | ||
skip = false, | ||
) { | ||
const useCustomKeywords = |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we instantiate customKeywords as an empty array that is overridden when sqleditor.extension.customAutocomplete
is defined?
SUMMARY
This commit includes the addition of
sqleditor.extension.customAutocomplete
to the extension registry, which allows for the utilization of custom keywords in SQL Lab autocomplete.TESTING INSTRUCTIONS
specs
ADDITIONAL INFORMATION