Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(TimeComparisonColumns): Remove currency formatter from percentage comparison column #28151

Merged

Conversation

rtexelm
Copy link
Member

@rtexelm rtexelm commented Apr 19, 2024

SUMMARY

This explicitly removes the currencyFormat entry in the % comparison column's config, prohibiting the currency symbol being applied to this column

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

AFTER:
percent-fixed

TESTING INSTRUCTIONS

  • enable time comparison
  • customize a column to add currency

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@eschutho eschutho merged commit 2ae7a36 into apache:table-time-comparison Apr 19, 2024
21 of 22 checks passed
betodealmeida pushed a commit that referenced this pull request Apr 25, 2024
@marcelo-musri
Copy link

Hi, my name is Marcelo Musri, from Argentina. Someone could help me customize currency format in my docker Superset. Thanks a lot

@rtexelm
Copy link
Member Author

rtexelm commented May 2, 2024

Hi @marcelo-musri this PR is for an experimental feature not available on the main superset branch. For a better forum to ask technical questions please join the superset community slack or go to the discussions tab, as these PR pages are meant for conversations concerning the specific pull requests.
Currency formatting is available in different ways, for example by customizing a big number chart or by editing a dataset and customizing the metric currency. If you have further questions please reach out in one of the forums mentioned above. Good luck!

eschutho pushed a commit that referenced this pull request Jun 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants