Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: call render operator function #28132

Merged
merged 1 commit into from
Apr 19, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -0,0 +1,122 @@
/**
* Licensed to the Apache Software Foundation (ASF) under one
* or more contributor license agreements. See the NOTICE file
* distributed with this work for additional information
* regarding copyright ownership. The ASF licenses this file
* to you under the Apache License, Version 2.0 (the
* "License"); you may not use this file except in compliance
* with the License. You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing,
* software distributed under the License is distributed on an
* "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
* KIND, either express or implied. See the License for the
* specific language governing permissions and limitations
* under the License.
*/
import React from 'react';
import {
render,
screen,
fireEvent,
waitFor,
} from 'spec/helpers/testing-library';
import { Comparator } from '@superset-ui/chart-controls';
import { ColorSchemeEnum } from '@superset-ui/plugin-chart-table';
import { FormattingPopoverContent } from './FormattingPopoverContent';

const mockOnChange = jest.fn();

const columns = [
{ label: 'Column 1', value: 'column1' },
{ label: 'Column 2', value: 'column2' },
];

const extraColorChoices = [
{
value: ColorSchemeEnum.Green,
label: 'Green for increase, red for decrease',
},
{
value: ColorSchemeEnum.Red,
label: 'Red for increase, green for decrease',
},
];

test('renders FormattingPopoverContent component', () => {
render(
<FormattingPopoverContent
onChange={mockOnChange}
columns={columns}
extraColorChoices={extraColorChoices}
/>,
);

// Assert that the component renders correctly
expect(screen.getByLabelText('Column')).toBeInTheDocument();
expect(screen.getAllByLabelText('Color scheme')).toHaveLength(2);
expect(screen.getAllByLabelText('Operator')).toHaveLength(2);
expect(screen.queryByLabelText('Left value')).not.toBeInTheDocument();
expect(screen.queryByLabelText('Right value')).not.toBeInTheDocument();
expect(screen.getByText('Apply')).toBeInTheDocument();
});

test('calls onChange when Apply button is clicked', async () => {
render(
<FormattingPopoverContent
onChange={mockOnChange}
columns={columns}
extraColorChoices={extraColorChoices}
/>,
);

// Simulate user interaction by clicking the Apply button
fireEvent.click(screen.getByText('Apply'));

// Assert that the onChange function is called with the correct config
await waitFor(() => {
expect(mockOnChange).toHaveBeenCalled();
});
});

test('renders the correct input fields based on the selected operator', async () => {
render(
<FormattingPopoverContent
onChange={mockOnChange}
columns={columns}
extraColorChoices={extraColorChoices}
/>,
);

// Select the 'Between' operator
fireEvent.change(screen.getAllByLabelText('Operator')[0], {
target: { value: Comparator.Between },
});
fireEvent.click(await screen.findByTitle('< x <'));

// Assert that the left and right value inputs are rendered
expect(await screen.findByLabelText('Left value')).toBeInTheDocument();
expect(await screen.findByLabelText('Right value')).toBeInTheDocument();
});

test('renders None for operator when Green for increase is selected', async () => {
render(
<FormattingPopoverContent
onChange={mockOnChange}
columns={columns}
extraColorChoices={extraColorChoices}
/>,
);

// Select the 'Green for increase' color scheme
fireEvent.change(screen.getAllByLabelText(/color scheme/i)[0], {
target: { value: ColorSchemeEnum.Green },
});

fireEvent.click(await screen.findByTitle(/green for increase/i));

// Assert that the operator is set to 'None'
expect(screen.getByText(/none/i)).toBeInTheDocument();
});
Original file line number Diff line number Diff line change
Expand Up @@ -124,7 +124,7 @@ const shouldFormItemUpdate = (
isOperatorMultiValue(prevValues.operator) !==
isOperatorMultiValue(currentValues.operator);

const operatorField = (showOnlyNone?: boolean) => (
const renderOperator = ({ showOnlyNone }: { showOnlyNone?: boolean } = {}) => (
<FormItem
name="operator"
label={t('Operator')}
Expand All @@ -141,7 +141,7 @@ const operatorField = (showOnlyNone?: boolean) => (
const renderOperatorFields = ({ getFieldValue }: GetFieldValue) =>
isOperatorNone(getFieldValue('operator')) ? (
<Row gutter={12}>
<Col span={6}>{operatorField()}</Col>
<Col span={6}>{renderOperator()}</Col>
</Row>
) : isOperatorMultiValue(getFieldValue('operator')) ? (
<Row gutter={12}>
Expand All @@ -157,7 +157,7 @@ const renderOperatorFields = ({ getFieldValue }: GetFieldValue) =>
<FullWidthInputNumber />
</FormItem>
</Col>
<Col span={6}>{operatorField}</Col>
<Col span={6}>{renderOperator()}</Col>
<Col span={9}>
<FormItem
name="targetValueRight"
Expand All @@ -173,7 +173,7 @@ const renderOperatorFields = ({ getFieldValue }: GetFieldValue) =>
</Row>
) : (
<Row gutter={12}>
<Col span={6}>{operatorField}</Col>
<Col span={6}>{renderOperator()}</Col>
<Col span={18}>
<FormItem
name="targetValue"
Expand Down Expand Up @@ -248,7 +248,7 @@ export const FormattingPopoverContent = ({
renderOperatorFields
) : (
<Row gutter={12}>
<Col span={6}>{operatorField(true)}</Col>
<Col span={6}>{renderOperator({ showOnlyNone: true })}</Col>
</Row>
)}
</FormItem>
Expand Down
Loading