-
Notifications
You must be signed in to change notification settings - Fork 13.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(Database): Clarify host value expected when running in docker #28124
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@@ -44,6 +44,8 @@ or for the purposes of this walkthrough, you can click the link below all these | |||
|
|||
<img src={useBaseUrl("/img/tutorial/tutorial_03a_database_connection_string_link.png" )} width="600" />{" "} <br/><br/> | |||
|
|||
Please note, if you are trying to connect to another locally running database such as Clickhouse (whether on host or another container), and you get the message `The port is closed.`, then you need to adjust the HOST to `host.docker.internal` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there something that's likely Clickhouse-specific here, or would it be best to remove the "such as Clickhouse" to keep it generic?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No need to mention Clickhouse, but hey... it's an improvement! Merging :)
docs/docs/creating-charts-dashboards/creating-your-first-dashboard.mdx
Outdated
Show resolved
Hide resolved
When running in Docker locally and attempting to connect to another DB also running in docker, the instructions are not clear enough.
…28124) Co-authored-by: Evan Rusackas <[email protected]>
SUMMARY
When running in Docker locally and attempting to connect to another DB also running in docker, the instructions are not clear enough, to help onboard new users, we should add a note clarifying what the HOST should be.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION