docs: deploy docs when merging to master #27956
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mistercrunch
requested review from
villebro,
geido,
eschutho,
rusackas,
betodealmeida,
nytai,
craig-rueda,
john-bodley,
kgabryje and
dpgaspar
as code owners
github-actions
bot
added
the
github_actions
villebro
approved these changes
Apr 9, 2024
|
@villebro luckily I think we caught this one before it created confusion as we were troubleshooting something else (.htaccess file changes not taking effect) and caught it while double-checking assumptions... @rusackas I'll let you merge this one since you wanted to use it for troubleshooting the |
I believe the intention is to have the docs aligned with what is on `master`, currently pushing on a release branch will trigger a potential regression. It could be reasonable for the docs to be aligned with the latest release, but if that was the intention we should deploy the docs as part of the release process, and avoid previous release branch from deploying the docs. I think this happened by mistake on https://github.com/apache/superset/pull/27390/files#diff-1f3b6eaac4370772e5f0d6cebab7906e0a83ce78e07f6ae8a239c06b33a420d4R9 when the intention was to trigger CI on release branches, not to deploy the docs.
mistercrunch
force-pushed
the
docs_only_master
branch
from
ecd3815
to
fd6dd48
Compare
EnxDev
pushed a commit
to EnxDev/superset
that referenced
this pull request
Apr 15, 2024
qleroy
pushed a commit
to qleroy/superset
that referenced
this pull request
Apr 28, 2024
jzhao62
pushed a commit
to jzhao62/superset
that referenced
this pull request
May 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
I believe the intention is to have the docs
aligned with what is on
master, currently pushing on a releasebranch will trigger a potential regression.
It could be reasonable for the docs to be aligned with the latest
release, but if that was the intention we should deploy the
docs as part of the release process, and avoid previous release branch
from deploying the docs.
I think this happened by mistake on
https://github.com/apache/superset/pull/27390/files#diff-1f3b6eaac4370772e5f0d6cebab7906e0a83ce78e07f6ae8a239c06b33a420d4R9
when the intention was to trigger CI on release branches, not to deploy
the docs.