Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fix-zh-translation-2 #27922

Merged
merged 2 commits into from
Apr 8, 2024
Merged

fix: fix-zh-translation-2 #27922

merged 2 commits into from
Apr 8, 2024

Conversation

listeng
Copy link
Contributor

@listeng listeng commented Apr 5, 2024

SUMMARY

This PR primarily corrects some inaccuracies in the Chinese translation. Hello, after #27794 we have updated some translations again.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

msgid "Centroid (Longitude and Latitude): "
msgstr "无效的经度/纬度" (incorrect) -> "中心点（经度/纬度）" (correct)

msgid "Chart height"
msgstr "图表标题" -> "图表高度"

msgid "Chart imported"
msgstr "图表标题" -> "图表已导入"

etc.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@github-actions github-actions bot added i18n Namespace | Anything related to localization i18n:chinese Translation related to Chinese language labels Apr 5, 2024
@listeng listeng changed the title fix-zh-translation-2 fix: fix-zh-translation-2 Apr 5, 2024
@john-bodley john-bodley added the review:checkpoint Last PR reviewed during the daily review standup label Apr 5, 2024
zhaoyongjie
zhaoyongjie approved these changes Apr 8, 2024
View reviewed changes
Copy link
Member

@zhaoyongjie zhaoyongjie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rusackas rusackas merged commit c5b7f7a into apache:master Apr 8, 2024
41 checks passed
@john-bodley john-bodley removed the review:checkpoint Last PR reviewed during the daily review standup label Apr 8, 2024
@michael-s-molina michael-s-molina added the v4.0 Label added by the release manager to track PRs to be included in the 4.0 branch label Apr 11, 2024
EnxDev pushed a commit to EnxDev/superset that referenced this pull request Apr 15, 2024
@listeng @EnxDev
fix: fix-zh-translation-2 (apache#27922)
1e0a710
@michael-s-molina michael-s-molina removed the v4.0 Label added by the release manager to track PRs to be included in the 4.0 branch label Apr 16, 2024
qleroy pushed a commit to qleroy/superset that referenced this pull request Apr 28, 2024
@listeng @qleroy
fix: fix-zh-translation-2 (apache#27922)
e9c6a5e
jzhao62 pushed a commit to jzhao62/superset that referenced this pull request May 16, 2024
@listeng @jzhao62
fix: fix-zh-translation-2 (apache#27922)
26f9eab
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rusackas rusackas rusackas approved these changes

@zhaoyongjie zhaoyongjie zhaoyongjie approved these changes

@villebro villebro Awaiting requested review from villebro

Assignees
No one assigned
Labels
i18n:chinese Translation related to Chinese language i18n Namespace | Anything related to localization size/XXL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@listeng @rusackas @zhaoyongjie @john-bodley @michael-s-molina