Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(docs): restoring search capability with new public key #27912

Merged
merged 1 commit into from
Apr 5, 2024

Conversation

rusackas
Copy link
Member

@rusackas rusackas commented Apr 5, 2024

SUMMARY

Docs search wasn't working... @sfirke updated the module (thanks!), but I later saw there's an API key error in my browser console. I searched Algolia for that key, and it looks like they may have rotated it. This is the new one!

Tested locally, and it works.

For those that are thinking "you can't just drop a key into your code like this!," Algolia states:

This is the public API key which can be safely used in your frontend code.This key is usable for search queries and it's also able to list the indices you've got access to.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@rusackas rusackas requested a review from sfirke April 5, 2024 05:37
@github-actions github-actions bot added the doc Namespace | Anything related to documentation label Apr 5, 2024
@rusackas rusackas changed the title Update docusaurus.config.js Fix(docs): restoring search capability with new public key Apr 5, 2024
@rusackas rusackas changed the title Fix(docs): restoring search capability with new public key fix(docs): restoring search capability with new public key Apr 5, 2024
@sfirke sfirke merged commit 3e6d966 into master Apr 5, 2024
35 of 38 checks passed
@sfirke sfirke deleted the fix-docs-search branch April 5, 2024 12:56
EandrewJones pushed a commit to UMD-ARLIS/superset that referenced this pull request Apr 5, 2024
EnxDev pushed a commit to EnxDev/superset that referenced this pull request Apr 12, 2024
qleroy pushed a commit to qleroy/superset that referenced this pull request Apr 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Namespace | Anything related to documentation preset-io size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants