chore: consolidate the Superset python package metadata #27884
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mistercrunch
force-pushed
the
rm_setup_cfg
branch
from
9d34016
to
2490961
Compare
john-bodley
reviewed
Apr 4, 2024
mypy.ini
Outdated
| @@ -0,0 +1,33 @@ | |||
| # Licensed to the Apache Software Foundation (ASF) under one | |||
There was a problem hiding this comment.
Why mypy.ini and not just add these to pyproject.toml. Per here this is a supported configuration setting for Mypy and it would ensure consistency with how we configure isort et al.
There was a problem hiding this comment.
ok I did this and pushed a bit further to bring tox.ini into pyproject.toml as well
|
@john-bodley let me know what you think as to whether |
Following up on #27859, where I introduced a new file `pyproject.toml` to set up the python project metadata, here I'd like to consolidate and modernize further by pushing as much as possible into pyproject.toml, except where things need to be dynamic, for which we'll keep using setup.py: - get rid of setup.cfg, everything there should be able to move to pyproject.toml - remove duplicate keys from setup.py and pyproject.toml - minimize/simplify setup.py
mistercrunch
force-pushed
the
rm_setup_cfg
branch
from
abfa9ad
to
830f4c5
Compare
qleroy
pushed a commit
to qleroy/superset
that referenced
this pull request
Apr 28, 2024
jzhao62
pushed a commit
to jzhao62/superset
that referenced
this pull request
May 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Following up on #27859, where
I introduced a new file
pyproject.tomlto set up thepython project metadata, here I'd like to consolidate and modernize
further by pushing as much as possible into pyproject.toml,
except where things need to be dynamic, for which we'll keep using
setup.py:
pyproject.toml
NOTE: we may be able to chisel a bit more at
setup.py, but it's going to me needed in some capacity since we have some dynamic parameters, notably theversionnumber we read and align frompackage.json. There's a tricky thing related toentry-pointswe could tackle.Also note that having
setup.pyprovides continuity for commands likepython setup.py sdistwhich is kind of nice.If we decided to make that a goal, we could fully kill
setup.pyand centralize on pyproject.toml, we're well on our way there.