[DO NOT MERGE] DEMO fix(time_comparison):Use Join queries when using time comparison #27853
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
john-bodley
added
the
review:checkpoint
- Add optional arg to extras schema in queryObject - Perfom a lett oute rjoin if the new arg is present so the query is processed in single query - Add tests for new fuctionality
- Raise an exception if the DB doesnt support subqueries or joins and user is trying to use the instant time comparison
Antonio-RiveroMartnez
force-pushed
the
joined_time_comparison
branch
from
7c33f6f
to
adc2386
Compare
john-bodley
removed
the
review:checkpoint
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
To facilitate the discussion related our experimental feature for time comparison, we're extracting out form the original PR all the back end changes related to how to create left outer join queries when time comparison is needed. Using JOIN statement would help tackling issues related to
Row Limitdiscussed in this issue. Right now we are raising an exception message to users that try to generate these joined queries on databases where JOINs are not supported.Known limitations:
time_offsetproperty in theQueryObject, meaning that it's not compatible with existing API that allows for multiple ranges using such property.time_offsetAPI that applies the joins on DataFrame levelBEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION