refactor: Move fetchTimeRange to core package #27852
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kgabryje
force-pushed
the
chore/move-fetchTimeRange-core
branch
from
362f808
to
2bcc15f
Compare
john-bodley
changed the title
eschutho
reviewed
Apr 2, 2024
| // "composite": false, | ||
| // "emitDeclarationOnly": false, | ||
| // "noEmit": true, | ||
| // "rootDir": "." |
eschutho
approved these changes
Apr 2, 2024
kgabryje
force-pushed
the
chore/move-fetchTimeRange-core
branch
from
2bcc15f
to
39ddf6e
Compare
mistercrunch
approved these changes
Apr 3, 2024
geido
approved these changes
Apr 3, 2024
Antonio-RiveroMartnez
pushed a commit
that referenced
this pull request
Apr 4, 2024
jzhao62
pushed a commit
to jzhao62/superset
that referenced
this pull request
Apr 4, 2024
EandrewJones
pushed a commit
to UMD-ARLIS/superset
that referenced
this pull request
Apr 5, 2024
Antonio-RiveroMartnez
pushed a commit
that referenced
this pull request
Apr 9, 2024
EnxDev
pushed a commit
to EnxDev/superset
that referenced
this pull request
Apr 12, 2024
betodealmeida
pushed a commit
that referenced
this pull request
Apr 25, 2024
betodealmeida
pushed a commit
that referenced
this pull request
Apr 25, 2024
(cherry picked from commit a498d6d)
qleroy
pushed a commit
to qleroy/superset
that referenced
this pull request
Apr 28, 2024
eschutho
pushed a commit
that referenced
this pull request
Jun 5, 2024
eschutho
pushed a commit
that referenced
this pull request
Jun 5, 2024
(cherry picked from commit a498d6d)
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Move
fetchTimeRangefunction and all its dependencies tosuperset-ui/coreto make it reusable in components defined incoreandchart-controlspackages.Also, sync
superset/errors.py::SupersetErrorTypewithpackages/superset-ui-core/src/query/types/Query.ts::ErrorTypeEnum.BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
No visual changes
TESTING INSTRUCTIONS
CI should pass
ADDITIONAL INFORMATION