-
Notifications
You must be signed in to change notification settings - Fork 13.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(dashboard): missing null check in error extra #27845
Merged
justinpark
merged 1 commit into
apache:master
from
justinpark:fix--unexpected-error-by-nul-extra
Apr 2, 2024
Merged
fix(dashboard): missing null check in error extra #27845
justinpark
merged 1 commit into
apache:master
from
justinpark:fix--unexpected-error-by-nul-extra
Apr 2, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #27845 +/- ##
==========================================
- Coverage 67.47% 67.41% -0.07%
==========================================
Files 1911 1919 +8
Lines 75020 75207 +187
Branches 8355 8423 +68
==========================================
+ Hits 50621 50701 +80
- Misses 22349 22446 +97
- Partials 2050 2060 +10
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
michael-s-molina
approved these changes
Apr 2, 2024
michael-s-molina
added
v4.0
Label added by the release manager to track PRs to be included in the 4.0 branch
v3.1
Label added by the release manager to track PRs to be included in the 3.1 branch
labels
Apr 3, 2024
michael-s-molina
pushed a commit
that referenced
this pull request
Apr 3, 2024
(cherry picked from commit f25795c)
jzhao62
pushed a commit
to jzhao62/superset
that referenced
this pull request
Apr 4, 2024
EandrewJones
pushed a commit
to UMD-ARLIS/superset
that referenced
this pull request
Apr 5, 2024
michael-s-molina
pushed a commit
that referenced
this pull request
Apr 8, 2024
(cherry picked from commit f25795c)
EnxDev
pushed a commit
to EnxDev/superset
that referenced
this pull request
Apr 12, 2024
qleroy
pushed a commit
to qleroy/superset
that referenced
this pull request
Apr 28, 2024
mistercrunch
added
🍒 3.1.3
🍒 4.0.1
🍒 4.0.2
🏷️ bot
A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels
labels
Jul 2, 2024
irublev
pushed a commit
to HighviewPower/superset
that referenced
this pull request
Oct 29, 2024
(cherry picked from commit c03faac)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
🏷️ bot
A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels
size/S
v3.1
Label added by the release manager to track PRs to be included in the 3.1 branch
v4.0
Label added by the release manager to track PRs to be included in the 4.0 branch
🍒 3.1.3
🍒 4.0.1
🍒 4.0.2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
As titled, this commit includes a null check for the extra value.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Before:
TESTING INSTRUCTIONS
Specs are included
ADDITIONAL INFORMATION