Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Select's storybook #27785

Merged
merged 1 commit into from
Mar 29, 2024

Conversation

michael-s-molina
Copy link
Member

SUMMARY

After the Storybook upgrades, the Select's storybook stopped working. This PR makes the adjustments to restore the functionality.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Screenshot 2024-03-29 at 11 26 42 Screenshot 2024-03-29 at 11 23 40

TESTING INSTRUCTIONS

Check that the Select's storybook is working as intended.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

Copy link

codecov bot commented Mar 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.71%. Comparing base (c0f8dfc) to head (20e767d).

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #27785   +/-   ##
=======================================
  Coverage   69.71%   69.71%           
=======================================
  Files        1920     1920           
  Lines       75234    75234           
  Branches     8423     8423           
=======================================
  Hits        52447    52447           
  Misses      20725    20725           
  Partials     2062     2062           
Flag Coverage Δ
javascript 57.40% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@john-bodley john-bodley merged commit 5b1d6b2 into apache:master Mar 29, 2024
31 checks passed
mz0in added a commit to mz0in/superset that referenced this pull request Mar 29, 2024
EandrewJones pushed a commit to UMD-ARLIS/superset that referenced this pull request Apr 5, 2024
EnxDev pushed a commit to EnxDev/superset that referenced this pull request Apr 12, 2024
qleroy pushed a commit to qleroy/superset that referenced this pull request Apr 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants