Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Adds Heatmap chart migration logic #27771

Merged

Conversation

michael-s-molina
Copy link
Member

SUMMARY

This PR adds the Heatmap chart migration logic (legacy ➡️ ECharts). Users can execute this migration using the CLI command and disable the legacy version with the VIZ_TYPE_DENYLIST configuration.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Screenshot 2024-03-28 at 16 56 49 Screenshot 2024-03-28 at 16 47 52

TESTING INSTRUCTIONS

1 - Upgrade a Heatmap chart using the CLI command
2 - Check the new chart
3 - Downgrade a Heatmap chart using the CLI command
4 - Check the legacy chart

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@michael-s-molina michael-s-molina requested a review from a team as a code owner March 28, 2024 19:58
@github-actions github-actions bot added the risk:db-migration PRs that require a DB migration label Mar 28, 2024
@michael-s-molina michael-s-molina changed the title feat: Add Heatmap chart migration logic feat: Adds Heatmap chart migration logic Mar 28, 2024
@michael-s-molina
Copy link
Member Author

@mistercrunch The bot added the risk:db-migration label to this PR even though there's no database migration.

Copy link

codecov bot commented Mar 28, 2024

Codecov Report

Attention: Patch coverage is 87.50000% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 69.82%. Comparing base (c0f8dfc) to head (f41df82).

Files Patch % Lines
superset/cli/viz_migrations.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #27771      +/-   ##
==========================================
+ Coverage   69.71%   69.82%   +0.11%     
==========================================
  Files        1920     1920              
  Lines       75234    75242       +8     
  Branches     8423     8423              
==========================================
+ Hits        52447    52538      +91     
+ Misses      20725    20642      -83     
  Partials     2062     2062              
Flag Coverage Δ
hive 48.93% <75.00%> (?)
mysql 77.88% <75.00%> (-0.01%) ⬇️
postgres 77.99% <75.00%> (-0.01%) ⬇️
presto 53.63% <75.00%> (?)
python 83.15% <87.50%> (+0.23%) ⬆️
sqlite 77.43% <75.00%> (-0.01%) ⬇️
unit 56.78% <87.50%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pull-request-size pull-request-size bot added size/L and removed size/M labels Mar 29, 2024
Copy link
Member

@kgabryje kgabryje left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@michael-s-molina michael-s-molina merged commit 356b0d8 into apache:master Mar 29, 2024
39 of 40 checks passed
@mistercrunch
Copy link
Member

calp

mz0in added a commit to mz0in/superset that referenced this pull request Mar 29, 2024
feat: Adds Heatmap chart migration logic (apache#27771)
EandrewJones pushed a commit to UMD-ARLIS/superset that referenced this pull request Apr 5, 2024
EnxDev pushed a commit to EnxDev/superset that referenced this pull request Apr 12, 2024
qleroy pushed a commit to qleroy/superset that referenced this pull request Apr 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
risk:db-migration PRs that require a DB migration size/L
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants