-
Notifications
You must be signed in to change notification settings - Fork 13.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Re-enable CI checks on release branches #27390
fix: Re-enable CI checks on release branches #27390
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #27390 +/- ##
=======================================
Coverage 67.34% 67.34%
=======================================
Files 1909 1909
Lines 74592 74592
Branches 8320 8320
=======================================
Hits 50235 50235
Misses 22305 22305
Partials 2052 2052
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Maybe the precommit hook isn't checking these files? The change in quotes seems unusual if so. |
Oh I didn't think of release branches when I made the changes, but seems totally reasonable that we'd run CI for release branches. I had to review the Total side note here, I'd love to keep things more DRY across actions (not repeating the branch name pattern for instance, or the |
@rusackas I think the check-yaml pre-commit hook isn't sophisticated/opinionated like that, it just makes sure the yaml is valid, it doesn't care about how it's styled |
(cherry picked from commit a54a24e)
(cherry picked from commit ed17139)
SUMMARY
#26766 restricted some CI workflows to run specifically on the
master
branch. This resulted in a problem for the release branches where running CI is really important when cherry-picking fixes into the branch. This PR adds a regex to allow CI to run on push events for release branches, restoring the previous behavior.Check filter-pattern-cheat-sheet for details about the regex. Dots don't need to be escaped.
TESTING INSTRUCTIONS
Restricted CI workflows should run only on
master
and branches that match the regex.ADDITIONAL INFORMATION