-
Notifications
You must be signed in to change notification settings - Fork 13.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Migration for single metric in Big Number with Time Comparison #27351
fix: Migration for single metric in Big Number with Time Comparison #27351
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #27351 +/- ##
==========================================
+ Coverage 67.37% 69.72% +2.35%
==========================================
Files 1908 1908
Lines 74550 74550
Branches 8317 8317
==========================================
+ Hits 50225 51982 +1757
+ Misses 22272 20515 -1757
Partials 2053 2053
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
We should move all to |
Also - apologies - super early in the history of Superset (pre-React!) I created multiple metrics-related control instead of creating a more versatile one. I think back then it was backend generate by wtforms and they had different components for single/multiple select... |
🏷️ preset:2024.8 |
…pache#27351) (cherry picked from commit ad6327d)
…pache#27351) (cherry picked from commit ad6327d)
…pache#27351) (cherry picked from commit ad6327d)
…pache#27351) (cherry picked from commit ad6327d)
…pache#27351) (cherry picked from commit ad6327d)
…pache#27351) (cherry picked from commit ad6327d)
…pache#27351) (cherry picked from commit ad6327d)
…pache#27351) (cherry picked from commit ad6327d)
…pache#27351) (cherry picked from commit ad6327d)
…pache#27351) (cherry picked from commit ad6327d)
…pache#27351) (cherry picked from commit ad6327d)
…pache#27351) (cherry picked from commit ad6327d)
SUMMARY
Due to changing
metrics
control tometric
in Big Number with Time Comparison chart, the existing charts were broken due to missingmetric
in form data. This PR adds a migration which takes the first item frommetrics
and applies it to the newmetric
control.BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
feat: Use standardized controls in Big Number with Time Comparison
)metric
control has a valueADDITIONAL INFORMATION
Current: 0.13 s
10+: 0.12 s
100+: 0.12 s
1000+: 0.20 s