Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(releasing): fixes npm script for release validation #27214

Merged
merged 1 commit into from
Feb 22, 2024
Merged

fix(releasing): fixes npm script for release validation #27214

merged 1 commit into from
Feb 22, 2024

Conversation

rusackas
Copy link
Member

SUMMARY

While attempting to use the npm script to validate the 4.0 release (first release I can do so!) I found an error with the path to the zip file missing the -source part of the path. I did a little sweeping while I was in there. :)

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

michael-s-molina
michael-s-molina approved these changes Feb 22, 2024
View reviewed changes
Copy link
Member

@michael-s-molina michael-s-molina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rusackas
Copy link
Member Author

Not sure what's wrong with the Translation checks. Looks like something wants to be upgraded to Node 18 very badly.

@michael-s-molina michael-s-molina merged commit 2a47edc into master Feb 22, 2024
28 of 29 checks passed
@michael-s-molina michael-s-molina added v4.0 Label added by the release manager to track PRs to be included in the 4.0 branch v3.1 Label added by the release manager to track PRs to be included in the 3.1 branch and removed v3.1 Label added by the release manager to track PRs to be included in the 3.1 branch labels Feb 23, 2024
michael-s-molina pushed a commit that referenced this pull request Mar 4, 2024
@rusackas @michael-s-molina
fix(releasing): fixes npm script for release validation (#27214)
ef2ca40 
(cherry picked from commit 2a47edc)
sfirke pushed a commit to sfirke/superset that referenced this pull request Mar 22, 2024
@rusackas @sfirke
fix(releasing): fixes npm script for release validation (apache#27214)
d394f0f
@rusackas rusackas deleted the validation-script-fix branch April 16, 2024 16:50
@mistercrunch mistercrunch added 🍒 4.0.0 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels labels Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michael-s-molina michael-s-molina michael-s-molina approved these changes

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS v4.0 Label added by the release manager to track PRs to be included in the 4.0 branch 🍒 4.0.0 🍒 4.0.1 🍒 4.0.2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@rusackas @michael-s-molina @mistercrunch