Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(import-datasources): Use "admin" user as default for importing datasources #27154

Merged
merged 7 commits into from
Feb 27, 2024
Merged

fix(import-datasources): Use "admin" user as default for importing datasources #27154

Changes from 2 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
468e952
Use "admin" user as default for importing datasources
ddxv Feb 19, 2024
ef1e28d
Merge branch 'master' into import-datasources-bugfix
ddxv Feb 20, 2024
893ccd1
Merge remote-tracking branch 'upstream/master' into import-datasource…
ddxv Feb 20, 2024
0cfa81c
Try with override_user
ddxv Feb 20, 2024
ce0b3bd
Set username as optional input for import_datasources with default of…
ddxv Feb 26, 2024
4993006
Set default and required=false in click.option
ddxv Feb 26, 2024
c38f17a
Fix typo in option help
ddxv Feb 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions superset/cli/importexport.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -176,6 +176,8 @@
from superset.commands.dataset.importers.dispatcher import ImportDatasetsCommand
from superset.commands.importers.v1.utils import get_contents_from_bundle

g.user = security_manager.find_user(username="admin")

Check warning on line 179 in superset/cli/importexport.py

View check run for this annotation

Codecov / codecov/patch

superset/cli/importexport.py#L179 

Added line #L179 was not covered by tests
ddxv marked this conversation as resolved.
Show resolved Hide resolved

if is_zipfile(path):
with ZipFile(path) as bundle:
contents = get_contents_from_bundle(bundle)
Expand Down
Loading