Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Plain error message when visiting a dashboard via permalink without permissions #27132

Merged
merged 1 commit into from
Feb 15, 2024

fix: Plain error message when visiting a dashboard via permalink with…

da10776
Select commit
Loading
Failed to load commit list.
Merged

fix: Plain error message when visiting a dashboard via permalink without permissions #27132

fix: Plain error message when visiting a dashboard via permalink with…
da10776
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Feb 15, 2024 in 0s

69.48% (+2.44%) compared to d2910b0

View this Pull Request on Codecov

69.48% (+2.44%) compared to d2910b0

Details

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (d2910b0) 67.04% compared to head (da10776) 69.48%.
Report is 2 commits behind head on master.

Files Patch % Lines
superset/views/core.py 25.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #27132      +/-   ##
==========================================
+ Coverage   67.04%   69.48%   +2.44%     
==========================================
  Files        1902     1902              
  Lines       74414    74451      +37     
  Branches     8306     8306              
==========================================
+ Hits        49888    51730    +1842     
+ Misses      22472    20667    -1805     
  Partials     2054     2054              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.