Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add permission to view and drill on Dashboard context #26798

Merged
merged 15 commits into from
Jan 29, 2024

Conversation

geido
Copy link
Member

@geido geido commented Jan 25, 2024

SUMMARY

Introducing the can_view_and_drill permission to enable drilling and read-only related chart interactions, such as "View as table" in Dashboard.

This is particularly useful in contexts like embedded dashboards where one would not want to give the can_explore permission but still allow certain charts' interactions within the dashboard context.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

N.A.

TESTING INSTRUCTIONS

All tests should pass

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

Copy link

codecov bot commented Jan 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (dfc614b) 67.22% compared to head (72d054e) 69.56%.
Report is 6 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #26798      +/-   ##
==========================================
+ Coverage   67.22%   69.56%   +2.33%     
==========================================
  Files        1895     1895              
  Lines       74211    74232      +21     
  Branches     8245     8251       +6     
==========================================
+ Hits        49891    51639    +1748     
+ Misses      22248    20522    -1726     
+ Partials     2072     2071       -1     
Flag Coverage Δ
hive 53.78% <100.00%> (?)
javascript 57.01% <100.00%> (+0.02%) ⬆️
mysql 77.94% <100.00%> (-0.03%) ⬇️
postgres 78.06% <100.00%> (+<0.01%) ⬆️
presto 53.73% <100.00%> (?)
python 83.02% <100.00%> (+4.81%) ⬆️
sqlite 77.64% <100.00%> (+<0.01%) ⬆️
unit 56.40% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@geido geido marked this pull request as ready for review January 25, 2024 17:45
Copy link
Member

@dpgaspar dpgaspar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't we need to create a permission on the backend?

@pull-request-size pull-request-size bot added size/L and removed size/M labels Jan 26, 2024
@geido geido changed the title chore: Add permission can_view_and_drill chore: Add permission to view and drill on Dashboard context Jan 26, 2024
Copy link
Member

@kgabryje kgabryje left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 small nit, otherwise lgtm!

@geido geido merged commit 6c029ce into master Jan 29, 2024
42 checks passed
eschutho pushed a commit to preset-io/superset that referenced this pull request Jan 31, 2024
sfirke pushed a commit to sfirke/superset that referenced this pull request Mar 22, 2024
@rusackas rusackas deleted the diego/ch77449/embedded_drill_permission branch April 16, 2024 16:53
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 4.0.0 labels Apr 17, 2024
@rohitpawar2811
Copy link

rohitpawar2811 commented Apr 24, 2024

@mistercrunch @rusackas
Hii
I'd like to point out that this MR changes are not available in the 4.0.0 release. I have checked both the git repo and inside the docker-image as well. However, according to the changelog, they should be included in 4.0.0. It is intentionally left because of some reason ?

@eschutho
Copy link
Member

Hi @rohitpawar2811 if you are looking specifically for the can_view_and_drill permission, it was removed in a later commit.

@agunoglu
Copy link

agunoglu commented May 2, 2024

hi I have all roles. And can not see drill down menu in superset graphs. Why?

@geido
Copy link
Member Author

geido commented May 10, 2024

hi I have all roles. And can not see drill down menu in superset graphs. Why?

Hello @agunoglu what roles do you currently have and what version are you on?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/L 🚢 4.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants