Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Calendar Heatmap): Add Back chart options for Calendar Heatmap #26230

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

Mattc1221
Copy link
Contributor

@Mattc1221 Mattc1221 commented Dec 10, 2023

SUMMARY

SIP: #26229

Adds chart options back to the Calendar Heatmap. The new list of Chart options is:

  • Color Scheme
  • Cell size
  • Cell padding
  • Cell Radius
  • Color Steps
  • Color Range
  • Number/Time Formatting
  • Legend Toggle
  • Show Values Toggle

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Screenshot 2023-12-10 at 1 46 10 PM

TESTING INSTRUCTIONS

  1. Choose a dataset with time data
  2. Select a calendar heatmap to chart
  3. Change the different Chart options and check that they work properly

ADDITIONAL INFORMATION

  • Has associated issue: [SIP-113] Calendar Heatmap Improvement  #26229
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@Mattc1221 Mattc1221 changed the title (fix) Add Back chart options for Calendar Heatmap fix(Calendar Heatmap): Add Back chart options for Calendar Heatmap Dec 10, 2023
Copy link

codecov bot commented Dec 10, 2023

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 69.18%. Comparing base (fca5b82) to head (12856bb).
Report is 1594 commits behind head on master.

Files with missing lines Patch % Lines
...ugins/legacy-plugin-chart-calendar/src/Calendar.js 0.00% 2 Missing ⚠️
...legacy-plugin-chart-calendar/src/transformProps.js 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #26230      +/-   ##
==========================================
- Coverage   69.18%   69.18%   -0.01%     
==========================================
  Files        1945     1945              
  Lines       75948    75950       +2     
  Branches     8458     8458              
==========================================
  Hits        52546    52546              
- Misses      21217    21219       +2     
  Partials     2185     2185              
Flag Coverage Δ
javascript 56.51% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@john-bodley
Copy link
Member

Thanks @Mattc1221 for the change. Could you help provide some more context, i.e., regarding the PR title you state "Add Back ..." which would imply that these features previously existed. If this is the case would you mind referencing the PR(s) where this was removed?

@john-bodley
Copy link
Member

Note ideally we hope to migrate the legacy calendar heatmap chart to ECharts, however currently there isn't feature parity. The concern is if we continue augmenting the legacy chart, the changes of eventually migrating to ECharts further diminishes.

Copy link
Member

@michael-s-molina michael-s-molina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @Mattc1221 and for writing the SIP. I'm just requesting changes to block this PR from being merged before the SIP is approved.

@rusackas
Copy link
Member

Just noting that the SIP is open for voting. Hoping we can get some votes, and unblock this PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants