chore: allow machine auth to generate CSRF token #26003
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9 tasks
john-bodley
requested review from
dpgaspar,
michael-s-molina and
john-bodley
dpgaspar
reviewed
Dec 5, 2023
superset/utils/machine_auth.py
Outdated
| @@ -143,6 +144,31 @@ def get_auth_cookies(user: User) -> dict[str, str]: | |||
|
|
|||
| return cookies | |||
|
|
|||
| @staticmethod | |||
| def get_auth_cookie_and_csrf_token(user: User) -> tuple[dict[str, str], str]: | |||
There was a problem hiding this comment.
We could check for app.config["WTF_CSRF_ENABLED"] here and DRY the code a bit more by removing get_auth_cookies
…e/machine_auth_gen_csrf_token
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #26003 +/- ##
==========================================
- Coverage 69.19% 69.18% -0.01%
==========================================
Files 1944 1944
Lines 75927 75932 +5
Branches 8451 8451
==========================================
+ Hits 52534 52537 +3
- Misses 21208 21210 +2
Partials 2185 2185
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
It's related to #28706 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The celery task get permissions through machine_auth.
The 'cache-warmup' task needs to call the '/api/v1/chart/warm_up_cache' endpoint .However, this endpoint is non GET requests and is therefore protected by CSRF.
Hence, when machine_auth retrieves the auth cookies, it also needs to generate a CSRF token.
This ensures that the Celery task can operate successfully.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION