Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(docker): add GUNICORN_LOGLEVEL env var #24308

Merged
merged 1 commit into from
Aug 30, 2024

Conversation

drummerwolli
Copy link
Contributor

SUMMARY

to debug gunicorn, it is useful to specify the log level. This env var gives the possibility to define it in the docker image

TESTING INSTRUCTIONS

in the docker sub directory, run this to build and run the new container:

docker build -t test . && docker run --name test -e GUNICORN_LOGLEVEL=debug -it test

after the build logs, you will see that gunicorn logs now way more verbose than when running with the the -e GUNICORN_LOGLEVEL=debug flag.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

to debug gunicorn, it is useful to specify the log level. This env var gives the possibility to define it in the docker image
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congrats on making your first PR and thank you for contributing to Superset! 🎉 ❤️

We hope to see you in our Slack community too! Not signed up? Use our Slack App to self-register.

@drummerwolli
Copy link
Contributor Author

bump, anything missing to merge this?

@rusackas
Copy link
Member

This seems harmles... closing/reopening to kick-start CI, then we can (hopefully/finally) merge it!

@rusackas rusackas closed this Aug 27, 2024
@rusackas rusackas reopened this Aug 27, 2024
@rusackas
Copy link
Member

Sorry this slipped through the cracks for so long.

@drummerwolli
Copy link
Contributor Author

@rusackas thanks for picking it up. anything missing from my side to get it merged?

Copy link
Member

@villebro villebro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, LGTM!

@villebro villebro merged commit 1f2f66b into apache:master Aug 30, 2024
35 checks passed
Copy link

codecov bot commented Aug 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.53%. Comparing base (ede6acd) to head (37001ce).
Report is 2285 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #24308   +/-   ##
=======================================
  Coverage   66.53%   66.53%           
=======================================
  Files        1957     1957           
  Lines       75623    75623           
  Branches     8224     8224           
=======================================
  Hits        50312    50312           
  Misses      23202    23202           
  Partials     2109     2109           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants