-
Notifications
You must be signed in to change notification settings - Fork 13.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(docker): add GUNICORN_LOGLEVEL env var #24308
Conversation
to debug gunicorn, it is useful to specify the log level. This env var gives the possibility to define it in the docker image
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
bump, anything missing to merge this? |
This seems harmles... closing/reopening to kick-start CI, then we can (hopefully/finally) merge it! |
Sorry this slipped through the cracks for so long. |
@rusackas thanks for picking it up. anything missing from my side to get it merged? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, LGTM!
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #24308 +/- ##
=======================================
Coverage 66.53% 66.53%
=======================================
Files 1957 1957
Lines 75623 75623
Branches 8224 8224
=======================================
Hits 50312 50312
Misses 23202 23202
Partials 2109 2109 ☔ View full report in Codecov by Sentry. |
SUMMARY
to debug gunicorn, it is useful to specify the log level. This env var gives the possibility to define it in the docker image
TESTING INSTRUCTIONS
in the docker sub directory, run this to build and run the new container:
docker build -t test . && docker run --name test -e GUNICORN_LOGLEVEL=debug -it test
after the build logs, you will see that gunicorn logs now way more verbose than when running with the the
-e GUNICORN_LOGLEVEL=debug
flag.ADDITIONAL INFORMATION