Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Text utils null value when reading module #24291

Merged
merged 1 commit into from
Jun 5, 2023
Merged

fix: Text utils null value when reading module #24291

merged 1 commit into from
Jun 5, 2023

Conversation

michael-s-molina
Copy link
Member

SUMMARY

Follow-up of #24250 that fixes an error when loading superset_text.yml.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Screenshot 2023-06-05 at 11 57 45

TESTING INSTRUCTIONS

Make sure the error does not happen when running with npm run dev-server

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@michael-s-molina michael-s-molina mentioned this pull request Jun 5, 2023
Merged
9 tasks
kgabryje
kgabryje approved these changes Jun 5, 2023
View reviewed changes
Copy link
Member

@kgabryje kgabryje left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the fix!

@michael-s-molina michael-s-molina merged commit 6a1f365 into apache:master Jun 5, 2023
@michael-s-molina michael-s-molina mentioned this pull request Jun 5, 2023
Merged
9 tasks
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 3.0.0 labels Mar 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kgabryje kgabryje kgabryje approved these changes

@rusackas rusackas Awaiting requested review from rusackas

@geido geido Awaiting requested review from geido

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/S 🚢 3.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@michael-s-molina @kgabryje @mistercrunch