Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DO NOT MERGE- for testing 2.1.1 release #24224

Closed
wants to merge 53 commits into from
Closed

DO NOT MERGE- for testing 2.1.1 release #24224

wants to merge 53 commits into from

Conversation

eschutho
Copy link
Member

SUMMARY

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Jun 1, 2023

Codecov Report

Merging #24224 (1c78268) into 2.1test (2817aeb) will decrease coverage by 11.01%.
The diff coverage is 63.57%.

❗ Current head 1c78268 differs from pull request most recent head 8e7e104. Consider uploading reports for the commit 8e7e104 to get more accurate results

@@             Coverage Diff              @@
##           2.1test   #24224       +/-   ##
============================================
- Coverage    67.54%   56.54%   -11.01%     
============================================
  Files         1882     1883        +1     
  Lines        72524    72702      +178     
  Branches      7887     7888        +1     
============================================
- Hits         48988    41108     -7880     
- Misses       21514    29570     +8056     
- Partials      2022     2024        +2     
Flag Coverage Δ
hive 52.74% <42.90%> (-0.06%) ⬇️
javascript 53.90% <51.85%> (+<0.01%) ⬆️
mysql ?
postgres ?
presto 52.67% <42.90%> (-0.06%) ⬇️
python 59.35% <64.72%> (-22.84%) ⬇️
sqlite ?
unit 52.61% <62.90%> (+0.11%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...t-ui-chart-controls/src/shared-controls/mixins.tsx 16.66% <ø> (ø)
...s/legacy-plugin-chart-calendar/src/controlPanel.ts 50.00% <ø> (ø)
...plugins/legacy-plugin-chart-heatmap/src/Heatmap.js 0.00% <0.00%> (ø)
...n-chart-handlebars/src/plugin/controls/columns.tsx 15.78% <0.00%> (+0.78%) ⬆️
...s/plugin-chart-pivot-table/src/PivotTableChart.tsx 0.00% <ø> (ø)
...n-chart-pivot-table/src/react-pivottable/Styles.js 0.00% <ø> (ø)
...src/dashboard/components/PropertiesModal/index.tsx 67.24% <ø> (ø)
.../src/explore/components/ControlPanelsContainer.tsx 69.76% <0.00%> (ø)
superset/charts/api.py 50.37% <ø> (-35.83%) ⬇️
superset/commands/importers/v1/examples.py 0.00% <0.00%> (ø)
... and 58 more

... and 258 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@eschutho eschutho force-pushed the 2.1 branch 4 times, most recently from b1ab42b to 54cb51a Compare June 6, 2023 23:44
@eschutho
Copy link
Member Author

eschutho commented Jun 9, 2023

/testenv up

@github-actions
Copy link
Contributor

github-actions bot commented Jun 9, 2023

@eschutho Ephemeral environment spinning up at http://34.217.21.59:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

@eschutho
Copy link
Member Author

eschutho commented Jun 9, 2023

/testenv up

@eschutho
Copy link
Member Author

/testenv up

@github-actions
Copy link
Contributor

@eschutho Ephemeral environment spinning up at http://34.219.107.205:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

@eschutho
Copy link
Member Author

eschutho commented Aug 7, 2023

/testenv up

@github-actions
Copy link
Contributor

github-actions bot commented Aug 7, 2023

@eschutho Ephemeral environment spinning up at http://54.202.87.4:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

@eschutho
Copy link
Member Author

/testenv up

@github-actions
Copy link
Contributor

@eschutho Ephemeral environment spinning up at http://35.91.96.29:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

@trixieboyle
Copy link

SUMMARY

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@eschutho eschutho closed this Aug 31, 2023
@github-actions
Copy link
Contributor

Ephemeral environment shutdown and build artifacts deleted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet