fix(migration): add log for values unseen in Slice.datasource_type
#23925
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
craig-rueda
reviewed
May 3, 2023
| session.add(slc) | ||
|
|
||
| else: | ||
| print( |
There was a problem hiding this comment.
Can we use a logger here? Print is a little nasty for aggregators like Datadog :P
craig-rueda
reviewed
May 3, 2023
| @@ -36,6 +37,8 @@ | |||
|
|
|||
| Base = declarative_base() | |||
|
|
|||
| logger = logging.getLogger() | |||
craig-rueda
reviewed
May 3, 2023
| session.add(slc) | ||
|
|
||
| else: | ||
| logger.info( |
craig-rueda
approved these changes
May 3, 2023
Codecov Report
@@ Coverage Diff @@
## master #23925 +/- ##
==========================================
- Coverage 68.10% 68.10% -0.01%
==========================================
Files 1941 1941
Lines 75020 75036 +16
Branches 8155 8155
==========================================
+ Hits 51096 51106 +10
- Misses 21841 21847 +6
Partials 2083 2083
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
eschutho
reviewed
May 3, 2023
|
|
||
| else: | ||
| logger.warn( | ||
| f"unknown value detected for slc.datasource_type: {slc.datasource_type}" |
There was a problem hiding this comment.
I would suggest also putting a log into line 60 above in case that's where the failure is.
|
@hughhhh don't we need to create a new dataset from the query? Rather than just changing the datasource_type to table? |
eschutho
reviewed
May 3, 2023
superset/migrations/versions/2023-03-27_12-30_7e67aecbf3f1_chart_ds_constraint.py
Show resolved
Hide resolved
eschutho
reviewed
May 3, 2023
superset/migrations/versions/2023-03-27_12-30_7e67aecbf3f1_chart_ds_constraint.py
Show resolved
Hide resolved
…rt_ds_constraint.py Co-authored-by: Elizabeth Thompson <[email protected]>
…rt_ds_constraint.py Co-authored-by: Elizabeth Thompson <[email protected]>
…rt_ds_constraint.py
eschutho
approved these changes
May 3, 2023
eschutho
reviewed
May 3, 2023
superset/migrations/versions/2023-03-27_12-30_7e67aecbf3f1_chart_ds_constraint.py
Outdated
Show resolved
Hide resolved
…rt_ds_constraint.py
sadpandajoe
pushed a commit
to preset-io/superset
that referenced
this pull request
May 4, 2023
…pache#23925) Co-authored-by: Elizabeth Thompson <[email protected]> (cherry picked from commit 3dc4de4)
|
🏷️ preset:2023.17 |
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION