Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: flask-appbuilder upgrade #17433

Closed
wants to merge 3 commits into from
Closed

chore: flask-appbuilder upgrade #17433

wants to merge 3 commits into from

Conversation

gnought
Copy link
Contributor

@gnought gnought commented Nov 13, 2021

SUMMARY

This upgrade is essential. flask-appbuilder 3.4.0 will fix the OAuth logout flow properly. Please see dpgaspar/Flask-AppBuilder#1707

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@villebro villebro requested a review from dpgaspar November 15, 2021 09:58
dpgaspar
dpgaspar requested changes Nov 15, 2021
View reviewed changes
Copy link
Member

@dpgaspar dpgaspar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gnought thank you for the PR, but please don't upgrade non related packages

@junlincc
Copy link
Member

@gnought Thank you for the PR! can you elaborate what problem you are trying to solve with this PR?

@gnought gnought closed this Nov 20, 2021
@gnought gnought deleted the feature/flask-appbuilder-upgrade branch November 20, 2021 05:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dpgaspar dpgaspar dpgaspar requested changes

Assignees
No one assigned
Labels
size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gnought @junlincc @dpgaspar