Skip to content

Commit

Permalink
chore: Support select_columns with getUserOwnedObjects and split getR…
Browse files Browse the repository at this point in the history
…ecentActivityObjs
  • Loading branch information
Vitor-Avila committed Jul 2, 2024
1 parent 9453b2e commit c3e7e21
Showing 1 changed file with 12 additions and 7 deletions.
19 changes: 12 additions & 7 deletions superset-frontend/src/views/CRUD/utils.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -126,17 +126,17 @@ const createFetchResourceMethod =
};

export const PAGE_SIZE = 5;
const getParams = (filters?: Filter[], select_columns?: string[]) => {
const getParams = (filters?: Filter[], selectColumns?: string[]) => {
const params = {
order_column: 'changed_on_delta_humanized',
order_direction: 'desc',
page: 0,
page_size: PAGE_SIZE,
filters,
select_columns,
select_columns: selectColumns,
};
if (!filters) delete params.filters;
if (!select_columns) delete params.select_columns;
if (!selectColumns) delete params.select_columns;
return rison.encode(params);
};

Expand Down Expand Up @@ -179,10 +179,10 @@ export const getUserOwnedObjects = (
value: `${userId}`,
},
],
select_columns?: string[],
selectColumns?: string[],
) =>
SupersetClient.get({
endpoint: `/api/v1/${resource}/?q=${getParams(filters, select_columns)}`,
endpoint: `/api/v1/${resource}/?q=${getParams(filters, selectColumns)}`,
}).then(res => res.json?.result);

export const getRecentActivityObjs = (
Expand All @@ -205,13 +205,18 @@ export const getRecentActivityObjs = (
export const getFilteredChartsandDashboards = (
addDangerToast: (arg1: string, arg2: any) => any,
filters: Filter[],
dashboardSelectColumns?: string[],
chartSelectColumns?: string[],
) => {
const newBatch = [
SupersetClient.get({
endpoint: `/api/v1/chart/?q=${getParams(filters)}`,
endpoint: `/api/v1/chart/?q=${getParams(filters, chartSelectColumns)}`,
}),
SupersetClient.get({
endpoint: `/api/v1/dashboard/?q=${getParams(filters)}`,
endpoint: `/api/v1/dashboard/?q=${getParams(
filters,
dashboardSelectColumns,
)}`,
}),
];
return Promise.all(newBatch)
Expand Down

0 comments on commit c3e7e21

Please sign in to comment.