Skip to content

Commit

Permalink
fix(explore): restored hidden field values has discarded
Browse files Browse the repository at this point in the history
  • Loading branch information
justinpark committed Jun 24, 2024
1 parent 4537ab6 commit a9ad6f2
Show file tree
Hide file tree
Showing 2 changed files with 36 additions and 1 deletion.
2 changes: 1 addition & 1 deletion superset-frontend/src/explore/reducers/exploreReducer.js
Original file line number Diff line number Diff line change
Expand Up @@ -267,7 +267,7 @@ export default function exploreReducer(state = {}, action) {
...form_data,
...restoredField,
},
hiddenFormData,
hiddenFormData: omit(hiddenFormData, fieldNames),
};
},
[actions.SLICE_UPDATED]() {
Expand Down
35 changes: 35 additions & 0 deletions superset-frontend/src/explore/reducers/exploreReducer.test.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,35 @@
/**
* Licensed to the Apache Software Foundation (ASF) under one
* or more contributor license agreements. See the NOTICE file
* distributed with this work for additional information
* regarding copyright ownership. The ASF licenses this file
* to you under the Apache License, Version 2.0 (the
* "License"); you may not use this file except in compliance
* with the License. You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing,
* software distributed under the License is distributed on an
* "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
* KIND, either express or implied. See the License for the
* specific language governing permissions and limitations
* under the License.
*/

import exploreReducer from './exploreReducer';
import { setStashFormData } from '../actions/exploreActions';

test('reset hiddenFormData on SET_STASH_FORM_DATA', () => {
const initialState = {
form_data: { a: 3, c: 4 },
};
const action = setStashFormData(true, ['a', 'c']);
const newState = exploreReducer(initialState, action);
expect(newState.form_data).toEqual({});
expect(newState.hiddenFormData).toEqual({ a: 3, c: 4 });
const restoreAction = setStashFormData(false, ['c']);
const newState2 = exploreReducer(newState, restoreAction);
expect(newState2.form_data).toEqual({ c: 4 });
expect(newState2.hiddenFormData).toEqual({ a: 3 });
});

0 comments on commit a9ad6f2

Please sign in to comment.