Skip to content

Commit

Permalink
fix(accessibility): logo outline on tab navigation, but not on click (#…
Browse files Browse the repository at this point in the history
  • Loading branch information
rusackas committed Sep 3, 2024
1 parent 72a520f commit 9c3eb8f
Showing 1 changed file with 7 additions and 5 deletions.
12 changes: 7 additions & 5 deletions superset-frontend/src/features/home/Menu.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -68,6 +68,12 @@ const StyledHeader = styled.header`
height: 100%;
object-fit: contain;
}
&:focus {
border-color: transparent;
}
&:focus-visible {
border-color: ${theme.colors.primary.dark1};
}
}
.navbar-brand-text {
border-left: 1px solid ${theme.colors.grayscale.light2};
Expand Down Expand Up @@ -306,11 +312,7 @@ export function Menu({
arrowPointAtCenter
>
{isFrontendRoute(window.location.pathname) ? (
<GenericLink
className="navbar-brand"
to={brand.path}
tabIndex={-1}
>
<GenericLink className="navbar-brand" to={brand.path}>
<img src={brand.icon} alt={brand.alt} />
</GenericLink>
) : (
Expand Down

0 comments on commit 9c3eb8f

Please sign in to comment.