fix(sqllab): race condition when updating same cursor position (#30141)

apache · Sep 4, 2024 · 880d634 · 880d634
1 parent ff449ad
commit 880d634
Showing 1 changed file with 7 additions and 1 deletion.
diff --git a/superset-frontend/src/SqlLab/components/AceEditorWrapper/index.tsx b/superset-frontend/src/SqlLab/components/AceEditorWrapper/index.tsx
@@ -142,9 +142,15 @@ const AceEditorWrapper = ({
 
       currentSelectionCache.current = selectedText;
     });
+
     editor.selection.on('changeCursor', () => {
       const cursor = editor.getCursorPosition();
-      onCursorPositionChange(cursor);
+      const { row, column } = cursorPosition;
+      // Prevent a maximum update depth exceeded error
+      // by skipping repeated updates to the same cursor position
+      if (cursor.row !== row && cursor.column !== column) {
+        onCursorPositionChange(cursor);
+      }
     });
 
     const { row, column } = cursorPosition;