fix: creating a new chart with dashboard time filters but filter can'…

…t apply again (#24405)
apache · Jun 20, 2023 · 6dba6e3 · 6dba6e3
1 parent 7a3a75a
commit 6dba6e3
Showing 1 changed file with 13 additions and 0 deletions.
diff --git a/superset-frontend/src/explore/actions/saveModalActions.js b/superset-frontend/src/explore/actions/saveModalActions.js
@@ -83,6 +83,19 @@ export const getSlicePayload = (
     adhocFilters = extractAddHocFiltersFromFormData(formDataFromSlice);
   }
 
+  if (
+    isEmpty(adhocFilters?.adhoc_filters) &&
+    isEmpty(formDataFromSlice) &&
+    formDataWithNativeFilters?.adhoc_filters?.length > 0
+  ) {
+    adhocFilters.adhoc_filters = [
+      {
+        ...formDataWithNativeFilters.adhoc_filters[0],
+        comparator: 'No filter',
+      },
+    ];
+  }
+
   const formData = {
     ...formDataWithNativeFilters,
     ...adhocFilters,