works

superset/utils/slack.py

@@ -33,7 +33,12 @@ def get_slack_client() -> WebClient:
 
 def get_user_avatar(email: str, client: WebClient = None) -> str:
     client = client or get_slack_client()
-
+    print("HEREHREHRHEHRHR")
+    print("HEREHREHRHEHRHR")
+    print("HEREHREHRHEHRHR")
+    print("HEREHREHRHEHRHR")
+    print("HEREHREHRHEHRHR")
+    print("HEREHREHRHEHRHR")
     try:
         response = client.users_lookupByEmail(email=email)
     except Exception as ex:

tests/integration_tests/users/api_tests.py

@@ -82,12 +82,17 @@ def test_avatar_valid_user_no_avatar(self):
         response = self.client.get("/api/v1/user/1/avatar.png", follow_redirects=False)
         assert response.status_code == 204
 
-    @patch("superset.utils.slack.get_user_avatar", return_value=AVATAR_URL)
     @with_config({"SLACK_API_TOKEN": "dummy", "SLACK_ENABLE_AVATARS": True})
-    def test_avatar_with_valid_user(self, mock):
+    def test_avatar_with_valid_user(self):
         self.login(ADMIN_USERNAME)
-
-        response = self.client.get("/api/v1/user/1/avatar.png", follow_redirects=False)
-        # mock.assert_called_once_with("[email protected]")
-        assert response.status_code == 204
-        # assert response.headers["Location"] == self.AVATAR_URL
+        with patch(
+            "superset.views.users.api.get_user_avatar", return_value=self.AVATAR_URL
+        ) as mock:
+            # with patch("superset.utils.slack.get_user_avatar", return_value=self.AVATAR_URL) as mock:
+            response = self.client.get(
+                "/api/v1/user/1/avatar.png", follow_redirects=False
+            )
+            # slack.get_user_avatar("[email protected]")
+            mock.assert_called_once_with("[email protected]")
+            assert response.status_code == 301
+            assert response.headers["Location"] == self.AVATAR_URL