ci: use git submodules for Chart Actions (#14211)

* Add chart-action submodules

* use local github actions for chart actions

* Run actions checkout for local checkout

* Run lint when PR is edited

* Remove path filter and dummy value

* Fix fetch-depth

* Test chart version bump

* Update maintainer to pass validation

* Update maintainer to pass validation

.github/workflows/superset-helm-lint.yml

@@ -2,16 +2,17 @@ name: Lint and Test Charts
 
 on:
   pull_request:
-    paths:
-      - 'helm/**'
+    types: [opened, edited, reopened, synchronize]
 
 jobs:
   lint-test:
     runs-on: ubuntu-latest
     steps:
-      - name: Checkout
+      - name: "Checkout ${{ github.ref }} ( ${{ github.sha }} )"
         uses: actions/checkout@v2
         with:
+          persist-credentials: false
+          submodules: recursive
           fetch-depth: 0
 
       - name: Set up Helm
@@ -24,7 +25,7 @@ jobs:
           python-version: 3.7
 
       - name: Set up chart-testing
-        uses: helm/chart-testing-action@v2.0.1
+        uses: ./.github/actions/chart-testing-action
 
       - name: Run chart-testing (list-changed)
         id: list-changed

.github/workflows/superset-helm-release.yml

@@ -11,9 +11,11 @@ jobs:
   release:
     runs-on: ubuntu-latest
     steps:
-      - name: Checkout
+      - name: "Checkout ${{ github.ref }} ( ${{ github.sha }} )"
         uses: actions/checkout@v2
         with:
+          persist-credentials: false
+          submodules: recursive
           fetch-depth: 0
 
       - name: Configure Git
@@ -27,7 +29,7 @@ jobs:
           version: v3.5.4
 
       - name: Run chart-releaser
-        uses: helm/chart-releaser-action@v1.2.0
+        uses: ./.github/actions/chart-releaser-action
         with:
           charts_dir: helm
         env:

.gitmodules

@@ -30,3 +30,9 @@
 [submodule ".github/actions/comment-on-pr"]
 	path = .github/actions/comment-on-pr
 	url = https://github.com/unsplash/comment-on-pr
+[submodule ".github/actions/chart-testing-action"]
+	path = .github/actions/chart-testing-action
+	url = https://github.com/helm/chart-testing-action
+[submodule ".github/actions/chart-releaser-action"]
+	path = .github/actions/chart-releaser-action
+	url = https://github.com/helm/chart-releaser-action

helm/superset/Chart.yaml

@@ -19,10 +19,10 @@ appVersion: "1.0"
 description: Apache Superset is a modern, enterprise-ready business intelligence web application
 name: superset
 maintainers:
-  - name: Chuan-Yen Chiang
-    email: cychiang0823@gmail.com
-    url: https://github.com/cychiang
-version: 0.1.0
+  - name: craig-rueda
+    email: craig@craigrueda.com
+    url: https://github.com/craig-rueda
+version: 0.1.1
 dependencies:
 - name: postgresql
   version: 10.2.0

helm/superset/values.yaml

@@ -372,5 +372,3 @@ nodeSelector: {}
 tolerations: []
 
 affinity: {}
-
-dummy: true