fix linting

apache · Apr 25, 2022 · 2b556b2 · 2b556b2
1 parent 658760b
commit 2b556b2
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 5 deletions.
diff --git a/superset/reports/commands/execute.py b/superset/reports/commands/execute.py
@@ -22,7 +22,6 @@
 from uuid import UUID
 
 import pandas as pd
-
 from celery.exceptions import SoftTimeLimitExceeded
 from flask_appbuilder.security.sqla.models import User
 from sqlalchemy.orm import Session
@@ -350,6 +349,7 @@ def _get_notification_content(self) -> NotificationContent:
                 else:
                     df = pd.read_csv(BytesIO(csv_data))
                     bio = BytesIO()
+                    # pylint: disable=abstract-class-instantiated
                     with pd.ExcelWriter(bio, engine="openpyxl") as writer:
                         df.to_excel(writer, index=False)
                     data = bio.getvalue()
@@ -669,9 +669,8 @@ def run(self) -> None:
             except Exception as ex:
                 raise ReportScheduleUnexpectedError(str(ex)) from ex
 
-    def validate(  # pylint: disable=arguments-differ
-        self, session: Session = None
-    ) -> None:
+    # pylint: disable=arguments-differ
+    def validate(self, session: Session = None) -> None:
         # Validate/populate model exists
         self._model = ReportScheduleDAO.find_by_id(self._model_id, session=session)
         if not self._model:

diff --git a/superset/reports/notifications/email.py b/superset/reports/notifications/email.py
@@ -135,7 +135,7 @@ def _get_content(self) -> EmailContent:
             """
         )
 
-        if self._content.data:
+        if self._content.data and self._content.data_format:
             attachment = {
                 __(
                     "%(name)s.%(format)s",