Fix lint

superset/common/query_context.py

@@ -61,7 +61,7 @@ class QueryContext:
 
     # TODO: Type datasource and query_object dictionary with TypedDict when it becomes
     #  a vanilla python type https://github.com/python/mypy/issues/5288
-    def __init__(
+    def __init__(  # pylint: disable=too-many-arguments
         self,
         *,
         datasource: BaseDatasource,

superset/common/query_context_factory.py

@@ -44,7 +44,7 @@ class QueryContextFactory:  # pylint: disable=too-few-public-methods
     def __init__(self) -> None:
         self._query_object_factory = create_query_object_factory()
 
-    def create(
+    def create(  # pylint: disable=too-many-arguments
         self,
         *,
         datasource: DatasourceDict,

superset/common/query_object.py

@@ -108,7 +108,7 @@ class QueryObject:  # pylint: disable=too-many-instance-attributes
     time_range: str | None
     to_dttm: datetime | None
 
-    def __init__(  # pylint: disable=too-many-locals
+    def __init__(  # pylint: disable=too-many-locals, too-many-arguments
         self,
         *,
         annotation_layers: list[dict[str, Any]] | None = None,

superset/config.py

@@ -43,7 +43,7 @@
 from flask_appbuilder.security.manager import AUTH_DB
 from flask_caching.backends.base import BaseCache
 from pandas import Series
-from pandas._libs.parsers import STR_NA_VALUES  # pylint: disable=no-name-in-module
+from pandas._libs.parsers import STR_NA_VALUES
 from sqlalchemy.engine.url import URL
 from sqlalchemy.orm.query import Query
 

superset/daos/base.py

@@ -49,7 +49,7 @@ class BaseDAO(Generic[T]):
     """
     id_column_name = "id"
 
-    def __init_subclass__(cls) -> None:  # pylint: disable=arguments-differ
+    def __init_subclass__(cls) -> None:
         cls.model_cls = get_args(
             cls.__orig_bases__[0]  # type: ignore  # pylint: disable=no-member
         )[0]

superset/db_engine_specs/README.md

@@ -547,7 +547,7 @@ Alternatively, it's also possible to impersonate users by implementing the `upda
 
 Support for authenticating to a database using personal OAuth2 access tokens was introduced in [SIP-85](https://github.com/apache/superset/issues/20300). The Google Sheets DB engine spec is the reference implementation.
 
-To add support for OAuth2 to a DB engine spec, the following attributes are needed:
+Note that this API is still experimental and evolving quickly, subject to breaking changes. Currently, to add support for OAuth2 to a DB engine spec, the following attributes are needed:
 
 ```python
 class BaseEngineSpec:

superset/db_engine_specs/postgres.py

@@ -209,7 +209,7 @@ class PostgresEngineSpec(BasicParametersMixin, PostgresBaseEngineSpec):
     encryption_parameters = {"sslmode": "require"}
 
     max_column_name_length = 63
-    try_remove_schema_from_table_name = False
+    try_remove_schema_from_table_name = False  # pylint: disable=invalid-name
 
     column_type_mappings = (
         (

superset/db_engine_specs/presto.py

@@ -1331,8 +1331,7 @@ def handle_cursor(cls, cursor: Cursor, query: Query) -> None:
                         completed_splits,
                         total_splits,
                     )
-                    if progress > query.progress:
-                        query.progress = progress
+                    query.progress = max(query.progress, progress)
                     db.session.commit()
             time.sleep(poll_interval)
             logger.info("Query %i: Polling the cursor for progress", query_id)

superset/models/slice.py

@@ -172,20 +172,17 @@ def get_datasource(self) -> SqlaTable | None:
 
     @renders("datasource_name")
     def datasource_link(self) -> Markup | None:
-        # pylint: disable=no-member
         datasource = self.datasource
         return datasource.link if datasource else None
 
     @renders("datasource_url")
     def datasource_url(self) -> str | None:
-        # pylint: disable=no-member
         if self.table:
             return self.table.explore_url
         datasource = self.datasource
         return datasource.explore_url if datasource else None
 
     def datasource_name_text(self) -> str | None:
-        # pylint: disable=no-member
         if self.table:
             if self.table.schema:
                 return f"{self.table.schema}.{self.table.table_name}"
@@ -198,7 +195,6 @@ def datasource_name_text(self) -> str | None:
 
     @property
     def datasource_edit_url(self) -> str | None:
-        # pylint: disable=no-member
         datasource = self.datasource
         return datasource.url if datasource else None
 

superset/utils/retries.py

@@ -22,7 +22,7 @@
 import backoff
 
 
-def retry_call(
+def retry_call(  # pylint: disable=too-many-arguments
     func: Callable[..., Any],
     *args: Any,
     strategy: Callable[..., Generator[int, None, None]] = backoff.constant,