Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MINOR]complete log info #3192

Closed
wants to merge 2 commits into from
Closed

Conversation

howardliu-cn
Copy link
Contributor

@howardliu-cn howardliu-cn commented Jan 13, 2020

[MINOR]complete log info in TransactionalState.java file

Copy link
Contributor

@kishorvpatil kishorvpatil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@Ethanlm
Copy link
Contributor

Ethanlm commented Jan 14, 2020

Since you have another PR open (#3193) for basically the same code, please update this PR to only fix the log issue. And since log issue is minor, please prefix "MINOR " to this PR title and commit message . Thanks

@howardliu-cn howardliu-cn changed the title complete log info [MINOR]complete log info Jan 15, 2020
@Ethanlm
Copy link
Contributor

Ethanlm commented Jan 23, 2020

Please keep only the second commit (the one about logs) and delete the first commit (about serialVersionUID) so to keep the PRs separated and focused. Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants