Skip to content

[SPARK-58747][PYTHON] Trim unnecessary commands from MANIFEST.in #57973

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nchammas wants to merge 3 commits into
base: master
Choose a base branch
from
+16 −15
Open

[SPARK-58747][PYTHON] Trim unnecessary commands from MANIFEST.in #57973

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b9f9d4d
merge unnecessary lines from MANIFEST.in into setup.py
nchammas Aug 12, 2026
1a7c293
explain what needs to be included
nchammas Aug 12, 2026
0736eab
pull jars in nested folders, too
nchammas Aug 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 10 additions & 12 deletions python/MANIFEST.in
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,20 +14,18 @@
# See the License for the specific language governing permissions and
# limitations under the License.

# Reference: https://setuptools.pypa.io/en/latest/userguide/miscellaneous.html
# NOTE
#
# The only files that need to be mentioned here are non-`.py` files that are not
# already included via explicit arguments to setup.cfg or setup.py like `package_data`,
# or via setuptools defaults which automatically look for license and README files.
#
# See:
# - https://setuptools.pypa.io/en/latest/userguide/datafiles.html
# - https://setuptools.pypa.io/en/latest/userguide/miscellaneous.html

recursive-include pyspark *.pyi py.typed *.json
recursive-include deps/jars *.jar
graft deps/bin
recursive-include deps/sbin spark-config.sh spark-daemon.sh start-history-server.sh stop-history-server.sh
recursive-include deps/data *.data *.txt
graft deps/licenses
recursive-include deps/examples *.py
recursive-include lib *.zip
include README.md
include LICENSE
include NOTICE

# Note that these commands are processed in the order they appear, so keep
# MANIFEST.in commands are processed in the order they appear, so keep
# this exclude at the end.
global-exclude *.py[cod] __pycache__ .DS_Store
7 changes: 4 additions & 3 deletions python/packaging/classic/setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -340,7 +340,7 @@ def run(self):
"pyspark.examples.src.main.python": "deps/examples",
},
package_data={
"pyspark.jars": ["*.jar"],
"pyspark.jars": ["**/*.jar"],
"pyspark.bin": ["*"],
"pyspark.sbin": [
"spark-config.sh",
Expand All @@ -351,12 +351,13 @@ def run(self):
"stop-history-server.sh",
],
"pyspark.python.lib": ["*.zip"],
"pyspark.data": ["*.txt", "*.data"],
"pyspark.data": ["**/*.txt", "**/*.data"],
"pyspark.licenses": ["*"],
"pyspark.examples.src.main.python": ["*.py", "*/*.py"],
"pyspark.examples.src.main.python": ["**/*.py"],
},
scripts=scripts,
license="Apache-2.0",
license_files=["LICENSE", "NOTICE"],
# Don't forget to update python/docs/source/getting_started/install.rst
# if you're updating the versions or dependencies.
install_requires=["py4j>=0.10.9.7,<0.10.9.10"],
Expand Down
1 change: 1 addition & 0 deletions python/packaging/client/setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -207,6 +207,7 @@
packages=connect_packages + test_packages,
include_package_data=True,
license="Apache-2.0",
license_files=["LICENSE", "NOTICE"],
# Don't forget to update python/docs/source/getting_started/install.rst
# if you're updating the versions or dependencies.
install_requires=[
Expand Down
1 change: 1 addition & 0 deletions python/packaging/connect/setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,6 +114,7 @@
packages=connect_packages,
include_package_data=True,
license="Apache-2.0",
license_files=["LICENSE", "NOTICE"],
# Don't forget to update python/docs/source/getting_started/install.rst
# if you're updating the versions or dependencies.
install_requires=[
Expand Down