-
Notifications
You must be signed in to change notification settings - Fork 29.2k
[SPARK-56882][SDP] Implement SCD1 Batch Processor; Target Column Projection #55991
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
AnishMahto
wants to merge
13
commits into
apache:master
Choose a base branch
from
AnishMahto:SPARK-56882-SCD1-project-target-columns-onto-microbatch
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+688
−17
Open
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
88aa032
validation
AnishMahto f8d2690
buff scaladoc
AnishMahto 27aa75b
use spark resolver
AnishMahto c155259
lingint
AnishMahto ca4e971
rebase conflict
AnishMahto 801a8b7
PR feedback
AnishMahto c36f910
rebase conflicts
AnishMahto 25387c3
PR feedback
AnishMahto be4b09c
scalalint LOCALE
AnishMahto f7411d8
project target columns onto microbatch
AnishMahto d750081
reuse applyToSchema
AnishMahto a42da1d
rebase conflict
AnishMahto b71ec8e
PR feedback
AnishMahto File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Question:
columnSelectioncan remove key columns (e.g.ExcludeColumnson a key, or a narrowIncludeColumnsthat omits keys). Will a later merge step still need those columns on this DataFrame?If keys must remain until after merge, we should validate here (or when constructing
ChangeArgs) thatchangeArgs.keysare not dropped. If merge runs before projection, or keys are re-injected elsewhere, could you add a brief note in the scaladoc on the expected pipeline order?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep we do require all keys remain in the column selection.
I added that validation in this PR during flow analysis time (well before flow execution, which is when this would actually be called) - see
requireKeysPresentInSelectedSchema.Flow analysis must always be done before flow execution, so there's no need to do additional user-friendly validation in this internal flow execution step. For unit testing purposes if a test is incorrectly setup, spark will just throw an unresolved column exception.