[SPARK-54078][SS] New test for StateStoreSuite SPARK-40492: maintenance before unload and remove infra from old test
#52877
+54
−54
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @volatile private var maintenancePaused: Boolean = false | ||
| private[spark] def setMaintenancePaused(maintPaused: Boolean): Unit = { | ||
| maintenancePaused = maintPaused | ||
| } |
There was a problem hiding this comment.
Thank you for making a PR, @liviazhu . However, the PR title looks wrong to me because this PR change the main source code under sql/core/src/main. Could you revise the PR title more properly?
liviazhu
changed the title
StateStoreSuite SPARK-40492: maintenance before unload and remove infra from old test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
The
SPARK-40492: maintenance before unloadtest is occasionally flaky even after refactors in #52783. This PR rewrites the test by using a new state store provider that counts number of times maintenance is triggered to test the functionality more directly. It also removes the hooks that were only used by the old test.Why are the changes needed?
Deflake the test
Does this PR introduce any user-facing change?
No
How was this patch tested?
Unit test, ran over 60 times
Was this patch authored or co-authored using generative AI tooling?
Generated-by: Claude 4