[SPARK-54159][INFRA] Fix pip install commands to use proper quotation marks
#52857
+16
−16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ok, but I also think we should have inside the ARG's to like |
HyukjinKwon
approved these changes
Nov 5, 2025
|
Thank you, @HyukjinKwon and @bjornjorgensen . Let me resolve the conflict and merge the AS-IS first. For |
dongjoon-hyun
added a commit
that referenced
this pull request
Nov 6, 2025
…on marks ### What changes were proposed in this pull request? This PR aims to a few `pip install` command to use proper quotation marks like the following. ``` -RUN python3.13 -m pip install --ignore-installed blinker>=1.6.2 # mlflow needs this +RUN python3.13 -m pip install --ignore-installed 'blinker>=1.6.2' # mlflow needs this ``` ``` -RUN python3.13 -m pip install numpy>=2.1 pyarrow>=18.0.0 six==1.16.0 pandas==2.3.3 scipy coverage matplotlib openpyxl grpcio==1.67.0 grpcio-status==1.67.0 lxml jinja2 && \ +RUN python3.13 -m pip install 'numpy>=2.1' 'pyarrow>=18.0.0' 'six==1.16.0' 'pandas==2.3.3' scipy coverage matplotlib openpyxl 'grpcio==1.67.0' 'grpcio-status==1.67.0' lxml jinja2 && \ ``` ### Why are the changes needed? SHELL handles `>=` before `pip install` command receives it. ### Does this PR introduce _any_ user-facing change? No behavior change because this is only changing infra. ### How was this patch tested? Pass the CIs. ### Was this patch authored or co-authored using generative AI tooling? No. This patch had conflicts when merged, resolved by Committer: Dongjoon Hyun <[email protected]> Closes #52857 from dongjoon-hyun/SPARK-54159. Authored-by: Dongjoon Hyun <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]> (cherry picked from commit 37689bf) Signed-off-by: Dongjoon Hyun <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR aims to a few
pip installcommand to use proper quotation marks like the following.Why are the changes needed?
SHELL handles
>=beforepip installcommand receives it.Does this PR introduce any user-facing change?
No behavior change because this is only changing infra.
How was this patch tested?
Pass the CIs.
Was this patch authored or co-authored using generative AI tooling?
No.