[SPARK-53847] Add ContinuousMemorySink for Real-time Mode testing #52550
+260
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
viirya
reviewed
Oct 10, 2025
| /** | ||
| * A sink that stores the results in memory. This [[org.apache.spark.sql.execution.streaming.Sink]] | ||
| * is primarily intended for use in unit tests and does not provide durability. | ||
| * This is mostly copied from MemorySink, except that the data needs to be availalbe not in |
There was a problem hiding this comment.
Suggested change
| * This is mostly copied from MemorySink, except that the data needs to be availalbe not in | |
| * This is mostly copied from MemorySink, except that the data needs to be available not in |
viirya
reviewed
Oct 10, 2025
Comment on lines
+166
to
+168
| if (endpointRef != null) { | ||
| memoryEndpoint.rpcEnv.stop(endpointRef) | ||
| } |
There was a problem hiding this comment.
If this commit is called for each batch, does it mean that the endpoint stops to work after that?
There was a problem hiding this comment.
Oh okay, I see. For each batch, there will be a new MemoryRealTimeRpcEndpoint created.
viirya
reviewed
Oct 10, 2025
| * for production-quality sinks. It's intended for use in tests. | ||
| * | ||
| */ | ||
| case class RealTimeRowWriterFactory( |
There was a problem hiding this comment.
I wonder why this doesn't follow the same naming pattern like ContinuousMemoryRowWriterFactory?
There was a problem hiding this comment.
Ah good question. The reason is because this code is going to be shared with the future RTM version of ConsoleStreamingWrite
There was a problem hiding this comment.
Though I can rename it if you fee strongly about it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Add a new in memory sink called "ContinuousMemorySink" to facilitate RTM testing. This sink differentiates from the existing MemorySink by immediately sending output back to the driver once the output is generated and not just at the end of the batch which is what the current MemorySink does.
Why are the changes needed?
To facilitate RTM testing
Does this PR introduce any user-facing change?
No
How was this patch tested?
Added simple test. There will be many RTM related tests that will be added in future PRs.
Was this patch authored or co-authored using generative AI tooling?