[SPARK-37466][SQL] Support subexpression elimination in higher order functions #51272
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kimahriman
force-pushed
the
hof-subexpr-elimination-local
branch
from
b36eb26 to
edf2f17
Compare
|
This builds on top of two other PRs which would be great to get some momentum on:
The changes required on top of those to actually implement the subexpression elimination in higher order functions is just in the last commit |
Kimahriman
force-pushed
the
hof-subexpr-elimination-local
branch
from
edf2f17 to
ebba29d
Compare
Kimahriman
force-pushed
the
hof-subexpr-elimination-local
branch
from
ebba29d to
02c661f
Compare
Kimahriman
force-pushed
the
hof-subexpr-elimination-local
branch
from
02c661f to
8aeb23f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Adds subexpression elimination support to higher order functions. Subexpressions are calculated on lambda functions and evaluated at the start of each iteration of the loop for each function.
Why are the changes needed?
Lack of subexpression elimination inside higher order functions can lead to significant and unexpected performance issues in complex queries and ETL jobs.
Does this PR introduce any user-facing change?
No, just a performance improvement.
How was this patch tested?
New UTs
Was this patch authored or co-authored using generative AI tooling?
No