[SPARK-52189][SQL] New golden file tests for NATURAL JOIN with GROUP BY, HAVING, ORDER BY and LCAs #50920
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vladimirg-db
force-pushed
the
vladimir-golubev_data/add-new-order-by-and-having-golden-file-tests
branch
from
746dfa5 to
34c0bfd
Compare
MaxGekk
approved these changes
May 19, 2025
|
+1, LGTM. Merging to master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Add new golden file tests for NATURAL JOIN with GROUP BY, HAVING, ORDER BY and LCAs
Why are the changes needed?
To cover Spark test gaps discovered during single-pass Analyzer implementation.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
New tests.
Was this patch authored or co-authored using generative AI tooling?
No.