[SPARK-52184][SQL] Wrap external engine JDBC syntax errors with a unified exception #50918
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cloud-fan
reviewed
May 16, 2025
cloud-fan
approved these changes
May 16, 2025
MaxGekk
reviewed
May 16, 2025
|
@alekjarmov Could you fix formatting, please: just re-generate the json file: |
alekjarmov
force-pushed
the
wrap-external-engine-errors
branch
from
6898200 to
8b143e5
Compare
alekjarmov
force-pushed
the
wrap-external-engine-errors
branch
from
8b143e5 to
2aacaf9
Compare
|
@cloud-fan Could you merge it please if everything is ok? |
MaxGekk
approved these changes
May 19, 2025
cloud-fan
reviewed
May 19, 2025
| @@ -3876,6 +3876,24 @@ | |||
| }, | |||
| "sqlState" : "42000" | |||
| }, | |||
| "JDBC_EXTERNAL_ENGINE_SYNTAX_ERROR" : { | |||
| "message" : [ | |||
| "JDBC external engine syntax error." | |||
There was a problem hiding this comment.
is it possible to always provide the compiled JDBC SQL text?
There was a problem hiding this comment.
Yes, I modified the error message to include the query.
cloud-fan
approved these changes
May 20, 2025
cloud-fan
reviewed
May 20, 2025
sql/core/src/main/scala/org/apache/spark/sql/jdbc/JdbcDialects.scala
Outdated
Show resolved
Hide resolved
|
The last commit just modified the version number in |
yhuang-db
pushed a commit
to yhuang-db/spark
that referenced
this pull request
Jun 9, 2025
…fied exception ### What changes were proposed in this pull request? This PR introduces a unified mechanism for handling SQL syntax errors thrown by external JDBC engines. It does so by: * Adding a new error condition: `JDBC_EXTERNAL_ENGINE_SYNTAX_ERROR`. * Extending multiple JdbcDialect implementations to provide best-effort syntax error detection via `isSyntaxErrorBestEffort`. * Updating integration test suites to include a new shared test that verifies the wrapping behavior. ### Why are the changes needed? Current behavior rethrows the error if it's a syntax error on the external engine. Having it wrapped in a Spark exception enables for easier data scince. ### Does this PR introduce _any_ user-facing change? The users would get a better error message. ### How was this patch tested? Adding new integration tests. ### Was this patch authored or co-authored using generative AI tooling? Coauthored with GitHub Copilot. Closes apache#50918 from alekjarmov/wrap-external-engine-errors. Lead-authored-by: alekjarmov <[email protected]> Co-authored-by: Wenchen Fan <[email protected]> Signed-off-by: Wenchen Fan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR introduces a unified mechanism for handling SQL syntax errors thrown by external JDBC engines. It does so by:
JDBC_EXTERNAL_ENGINE_SYNTAX_ERROR.isSyntaxErrorBestEffort.Why are the changes needed?
Current behavior rethrows the error if it's a syntax error on the external engine. Having it wrapped in a Spark exception enables for easier data scince.
Does this PR introduce any user-facing change?
The users would get a better error message.
How was this patch tested?
Adding new integration tests.
Was this patch authored or co-authored using generative AI tooling?
Coauthored with GitHub Copilot.